New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support six.with_metaclass #3364

merged 7 commits into from May 17, 2017


None yet
3 participants

gvanrossum commented May 15, 2017

Fixes #1764

This doesn't add support for @six.add_metaclass(M) -- if that's required we'll add it later (we should open a separate issue for that).

@gvanrossum gvanrossum referenced this pull request May 15, 2017


Support GenericMeta #3366

Show outdated Hide outdated mypy/
Show outdated Hide outdated mypy/
Show outdated Hide outdated test-data/unit/check-classes.test

This comment has been minimized.

Show comment
Hide comment

gvanrossum May 16, 2017


@JukkaL: Do you have time for another review?


gvanrossum commented May 16, 2017

@JukkaL: Do you have time for another review?


Looks good to me now.

@gvanrossum gvanrossum merged commit 3f2668d into master May 17, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@gvanrossum gvanrossum deleted the six-metaclass branch May 17, 2017

pjdelport added a commit to pjdelport/django-payfast that referenced this pull request Dec 5, 2017

Use the six package, rather than Django's vendored version
This allows Mypy to understand six.with_metaclass:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment