New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix None slice bounds with strict-optional #3445

Merged
merged 4 commits into from May 29, 2017

Conversation

Projects
None yet
3 participants
@miedzinski
Contributor

miedzinski commented May 24, 2017

Fixes #3442.

Show outdated Hide outdated test-data/unit/check-expressions.test
@@ -998,6 +998,7 @@ a[:o] # E: Slice index must be an integer or None
[builtins fixtures/slice.pyi]
[case testNoneSliceBounds]
# flags: --strict-optional

This comment has been minimized.

@JelleZijlstra

JelleZijlstra May 24, 2017

Collaborator

We should probably test this both with and without strict-optional.

@JelleZijlstra

JelleZijlstra May 24, 2017

Collaborator

We should probably test this both with and without strict-optional.

Show outdated Hide outdated mypy/checkexpr.py
@@ -1893,10 +1893,11 @@ def analyze_super(self, e: SuperExpr, is_lvalue: bool) -> Type:
return AnyType()
def visit_slice_expr(self, e: SliceExpr) -> Type:
expected = UnionType.make_union([NoneTyp(), self.named_type('builtins.int')])

This comment has been minimized.

@gvanrossum

gvanrossum May 25, 2017

Member

Should probably use typeanal.make_optional_type() instead.

@gvanrossum

gvanrossum May 25, 2017

Member

Should probably use typeanal.make_optional_type() instead.

This comment has been minimized.

@miedzinski

miedzinski May 25, 2017

Contributor

I was looking for such function/method, but couldn't find it. Thanks!

@miedzinski

miedzinski May 25, 2017

Contributor

I was looking for such function/method, but couldn't find it. Thanks!

@gvanrossum gvanrossum merged commit 9ec8a95 into python:master May 29, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum May 29, 2017

Member

Thanks!

Member

gvanrossum commented May 29, 2017

Thanks!

carljm added a commit to carljm/mypy that referenced this pull request May 30, 2017

Merge branch 'master' into module-alias
* master: (23 commits)
  Make return type of open() more precise (#3477)
  Add test cases that delete a file during incremental checking (#3461)
  Parse each format-string component separately (#3390)
  Don't warn about returning Any if it is a proper subtype of the return type (#3473)
  Add __setattr__ support (#3451)
  Remove bundled lib-typing (#3337)
  Move version of extensions to post-release (#3348)
  Fix None slice bounds with strict-optional (#3445)
  Allow NewType subclassing NewType. (#3465)
  Add console scripts (#3074)
  Fix 'variance' label.
  Change label for variance section to just 'variance' (#3429)
  Better error message for invalid package names passed to mypy (#3447)
  Fix last character cut in html-report if file does not end with newline (#3466)
  Print pytest output as it happens (#3463)
  Add mypy roadmap (#3460)
  Add flag to avoid interpreting arguments with a default of None as Optional (#3248)
  Add type checking plugin support for functions (#3299)
  Mismatch of inferred type and return type note (#3428)
  Sync typeshed (#3449)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment