Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix crash when serializing a type-ignored property setter #3493
This fixes two issues from #3491: a crash in serialization and an incorrect error "Function is missing a type annotation for one or more arguments". Both had the same root cause; we were skipping semantic analysis for the function body if mypy was unhappy with the property.setter decorator.
referenced this pull request
Jun 2, 2017
Thanks, it turns out the issue was that the cache isn't written when there is an error in the file, and I had a reveal_type(), which counts as an error.
In other news, it turns out that this PR also fixes the other bug reported in #3491 (the spurious "missing type annotation" error). Therefore, I added tests both with and without