New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spurious "cycle in function expansion" errors. #3504

Merged
merged 1 commit into from Jun 6, 2017

Conversation

Projects
None yet
2 participants
@gvanrossum
Member

gvanrossum commented Jun 6, 2017

Most of these (at least) seem to be due to a function being analyzed
multiple times, and the 'expanded' list filling up with 2 or more
references to the same FuncDef.

If there are other reasons they will still trigger the same error, but
at least for mypy itself, the error no longer appears with this simple
fix.

Fixes #3503.

Fix spurious "cycle in function expansion" errors.
Most of these (at least) seem to be due to a function being analyzed
multiple times, and the 'expanded' list filling up with 2 or more
references to the same FuncDef.

If there are other reasons they will still trigger the same error, but
at least for mypy itself, the error no longer appears with this simple
fix.

@ilinum ilinum self-assigned this Jun 6, 2017

@ilinum

ilinum approved these changes Jun 6, 2017

Should be good to merge once the build passes!

@gvanrossum gvanrossum merged commit cbb4ba8 into master Jun 6, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@gvanrossum gvanrossum deleted the fix-cycle branch Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment