New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to ignore the mypy version in cache metadata #3641

Merged
merged 1 commit into from Jul 5, 2017

Conversation

Projects
None yet
2 participants
@gvanrossum
Member

gvanrossum commented Jun 30, 2017

When testing cache improvement I'd like to be able to use cache files produced by a previous mypy version.

@@ -891,7 +891,7 @@ def find_cache_meta(id: str, path: str, manager: BuildManager) -> Optional[Cache
return None
# Ignore cache if generated by an older mypy version.
if (m.version_id != manager.version_id
if ((m.version_id != manager.version_id and not manager.options.skip_version_check)

This comment has been minimized.

@ethanhs

ethanhs Jul 1, 2017

Collaborator

Minorest nit: The or clauses here break over a line, I think for consistency it'd be nice to do so with the and.

@ethanhs

ethanhs Jul 1, 2017

Collaborator

Minorest nit: The or clauses here break over a line, I think for consistency it'd be nice to do so with the and.

This comment has been minimized.

@gvanrossum

gvanrossum Jul 1, 2017

Member

I disagree, since and binds tighter and there is room.

@gvanrossum

gvanrossum Jul 1, 2017

Member

I disagree, since and binds tighter and there is room.

This comment has been minimized.

@ethanhs

ethanhs Jul 1, 2017

Collaborator

No worries, a style choice I suppose. Everything LGTM.

@ethanhs

ethanhs Jul 1, 2017

Collaborator

No worries, a style choice I suppose. Everything LGTM.

@gvanrossum gvanrossum merged commit 138f478 into python:master Jul 5, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gvanrossum gvanrossum deleted the gvanrossum:skip-version-check branch Jul 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment