New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject isinstance() with TypedDict and NewType #3654

Merged
merged 1 commit into from Jul 4, 2017

Conversation

Projects
None yet
2 participants
@JukkaL
Collaborator

JukkaL commented Jul 4, 2017

These can't be used with isinstance() at runtime.

Reject isinstance() with TypedDict and NewType
These can't be used for runtime type checking at runtime.
@JukkaL

This comment has been minimized.

Show comment
Hide comment
@JukkaL

JukkaL Jul 4, 2017

Collaborator

The test failures are flakes (#3543).

Collaborator

JukkaL commented Jul 4, 2017

The test failures are flakes (#3543).

@@ -8,6 +8,7 @@ class type:
class tuple: pass
class function: pass
class ellipsis: pass

This comment has been minimized.

@ilevkivskyi

ilevkivskyi Jul 4, 2017

Collaborator

Is this necessary? It looks like you don't use ellipses in the added tests.

@ilevkivskyi

ilevkivskyi Jul 4, 2017

Collaborator

Is this necessary? It looks like you don't use ellipses in the added tests.

This comment has been minimized.

@JukkaL

JukkaL Jul 4, 2017

Collaborator

The stub for mypy_extensions uses ....

@JukkaL

JukkaL Jul 4, 2017

Collaborator

The stub for mypy_extensions uses ....

@JukkaL JukkaL merged commit 5928551 into master Jul 4, 2017

3 of 4 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gvanrossum gvanrossum deleted the bad-instance branch Jul 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment