New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress any errors found in a boolean expression after filtering out all possible types. #3666

Merged
merged 1 commit into from Jul 12, 2017

Conversation

Projects
None yet
3 participants
@rowillia
Contributor

rowillia commented Jul 5, 2017

This fixes #3643

@rowillia rowillia referenced this pull request Jul 6, 2017

Closed

Release mypy 0.520 #3655

@ethanhs

This comment has been minimized.

Show comment
Hide comment
@ethanhs

ethanhs Jul 7, 2017

Collaborator

LGTM (sorry for taking so long to review).

Collaborator

ethanhs commented Jul 7, 2017

LGTM (sorry for taking so long to review).

@rowillia

This comment has been minimized.

Show comment
Hide comment
@rowillia

rowillia Jul 12, 2017

Contributor

Ping @JukkaL ! Mind taking a quick look?

Contributor

rowillia commented Jul 12, 2017

Ping @JukkaL ! Mind taking a quick look?

@gvanrossum gvanrossum merged commit c106579 into python:master Jul 12, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Jul 12, 2017

Member

Thanks!

(If you want to do a little cleanup, turning disable/enable-errors into a context manager would perhaps be nice... There are many other things in mypy that would also be better off as context managers.)

Member

gvanrossum commented Jul 12, 2017

Thanks!

(If you want to do a little cleanup, turning disable/enable-errors into a context manager would perhaps be nice... There are many other things in mypy that would also be better off as context managers.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment