New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in --quick mode when aliases are re-exported #3740

Merged
merged 1 commit into from Jul 19, 2017

Conversation

Projects
None yet
2 participants
@ilevkivskyi
Collaborator

ilevkivskyi commented Jul 19, 2017

Fixes #3355

This happens since dependencies in --quick mode are not rechecked, therefore we need to put something in place of the outdated values.

In general, I could imagine there are similar problems with outdated values in --quick mode, so that it is better to move towards fine grained incremental, that actually rechecks dependencies.

@gvanrossum gvanrossum merged commit bc45237 into python:master Jul 19, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Jul 19, 2017

Member

Wow it's beautiful! (Especially the test. Amazing that you could repro that from those tracebacks.)

Member

gvanrossum commented Jul 19, 2017

Wow it's beautiful! (Especially the test. Amazing that you could repro that from those tracebacks.)

@ilevkivskyi ilevkivskyi deleted the ilevkivskyi:fix-new-quick-crash branch Jul 19, 2017

@ilevkivskyi

This comment has been minimized.

Show comment
Hide comment
@ilevkivskyi

ilevkivskyi Jul 19, 2017

Collaborator

Amazing that you could repro that from those tracebacks

Thanks! This is why I became a scientist -- I like to investigate, but it turns out there are interesting cases for investigations not only in science :-)

Collaborator

ilevkivskyi commented Jul 19, 2017

Amazing that you could repro that from those tracebacks

Thanks! This is why I became a scientist -- I like to investigate, but it turns out there are interesting cases for investigations not only in science :-)

gvanrossum added a commit to gvanrossum/mypy that referenced this pull request Jul 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment