GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There are no special checks for improper use (similar to with_metaclass).
Consistency checks are handled like in any other metaclass.
duplicate tests for with_metaclass
refactor and add checks for multiple definitions
make metaclass an Expression
OK, this one can be now updated after #3848 is merged (plus the suggested tests).
Merge remote-tracking branch 'upstream/master' into metaclass-getattr
Thanks, looks good! Just two small comments.
This actually fails at runtime because of a metaclass conflict. Is it easy to detect this? If this is non-trivial, then I think we should not include it in this PR.
I believe this is not caught because the base class Generic is removed earlier in the analysis. It doesn't seem obvious to me how this should be fixed.
OK, them it is not easy to support this.
fix Any test
Thanks, looks good now!