New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type checking decorated method overrides #3918

Merged
merged 4 commits into from Sep 13, 2017

Conversation

Projects
None yet
3 participants
@JukkaL
Collaborator

JukkaL commented Sep 5, 2017

The fix turned out to be pretty complicated, as there were a bunch of
untested method overriding scenarios which weren't quite right. I
fixed any related issues that I encountered, though I'm not certain
whether some of the issues were hidden previously by other bugs. I
also added tests for some related, previously untested scenarios.

Fixes #1441.

Fix type checking decorated method overrides
The fix turned out to be pretty complicated, as there were a bunch of
untested method overriding scenarios which weren't quite right. I
fixed any related issues that I encountered, though I'm not certain
whether some of the issues were hidden previously by other bugs. I
also added tests for some related, previously untested scenarios.

Fixes #1441.
@JukkaL

This comment has been minimized.

Show comment
Hide comment
@JukkaL

JukkaL Sep 5, 2017

Collaborator

This is ready for review, but don't merge this yet -- I have some outstanding fixes to internal Dropbox code bases that I want to land first before merging this.

Collaborator

JukkaL commented Sep 5, 2017

This is ready for review, but don't merge this yet -- I have some outstanding fixes to internal Dropbox code bases that I want to land first before merging this.

@ilevkivskyi

This comment has been minimized.

Show comment
Hide comment
@ilevkivskyi

ilevkivskyi Sep 5, 2017

Collaborator

It looks like you didn't update all tests, now all types are wrapped in quotes "...".

Collaborator

ilevkivskyi commented Sep 5, 2017

It looks like you didn't update all tests, now all types are wrapped in quotes "...".

@ilevkivskyi

Not a real review, just two random comments. Also this reminds me that there is an old related PR #3263, @kirbyfan64 are you still working on it?

Show outdated Hide outdated mypy/checker.py
Show outdated Hide outdated mypy/checker.py

@gvanrossum gvanrossum self-requested a review Sep 11, 2017

@gvanrossum

This looks ready to merge to me.

I should also mention that our internal codebase is now clear for this PR.

Show outdated Hide outdated mypy/checker.py

@JukkaL JukkaL merged commit a771113 into master Sep 13, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@JukkaL

This comment has been minimized.

Show comment
Hide comment
@JukkaL

JukkaL Sep 13, 2017

Collaborator

What about writable properties?

These should be invariant, similar to regular attributes.

Collaborator

JukkaL commented Sep 13, 2017

What about writable properties?

These should be invariant, similar to regular attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment