New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash on unexpected PY2 except syntax #4011

Merged
merged 5 commits into from Sep 26, 2017

Conversation

Projects
None yet
2 participants
@gvanrossum
Member

gvanrossum commented Sep 26, 2017

Fixes #3772

Still needs a test.

@ethanhs

Looks good 👍

@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Sep 26, 2017

Member

Whoa, needs tests first.

Member

gvanrossum commented Sep 26, 2017

Whoa, needs tests first.

@ethanhs

This comment has been minimized.

Show comment
Hide comment
@ethanhs

ethanhs Sep 26, 2017

Collaborator

Sorry, yes it needs tests. I meant the changes look good (beyond needing tests).

Collaborator

ethanhs commented Sep 26, 2017

Sorry, yes it needs tests. I meant the changes look good (beyond needing tests).

@ethanhs

This comment has been minimized.

Show comment
Hide comment
@ethanhs

ethanhs Sep 26, 2017

Collaborator

Travis flaked on 3.7, so I restarted it.

Collaborator

ethanhs commented Sep 26, 2017

Travis flaked on 3.7, so I restarted it.

@gvanrossum gvanrossum merged commit 5252e82 into python:master Sep 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gvanrossum gvanrossum deleted the gvanrossum:fix-except-tuple branch Sep 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment