New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recent crashes in forward refs #4120

Merged
merged 3 commits into from Oct 25, 2017

Conversation

Projects
None yet
3 participants
@ilevkivskyi
Collaborator

ilevkivskyi commented Oct 13, 2017

Fixes #4097

This adds processing of forward references in two nodes that were previously missing: OverloadedFuncDef and NewTypeExpr.info.

(Note that some tests use # type: ignore, the original crash was discovered during serialization with errors ignored.)

@Daenyth

This fixes the crash I reported

@Daenyth

This comment has been minimized.

Show comment
Hide comment
@Daenyth

Daenyth Oct 24, 2017

I'd appreciate if this could be merged soon so that I can upgrade from 0.521

Daenyth commented Oct 24, 2017

I'd appreciate if this could be merged soon so that I can upgrade from 0.521

@JukkaL

This comment has been minimized.

Show comment
Hide comment
@JukkaL

JukkaL Oct 24, 2017

Collaborator

Can you fix the merge conflict?

Collaborator

JukkaL commented Oct 24, 2017

Can you fix the merge conflict?

@JukkaL

Thanks for the fixes! This looks good, but I'll still need to test this with internal Dropbox codebases once the merge conflict has been resolved.

@ilevkivskyi

This comment has been minimized.

Show comment
Hide comment
@ilevkivskyi

ilevkivskyi Oct 25, 2017

Collaborator

@JukkaL

Can you fix the merge conflict?

Fixed!

Collaborator

ilevkivskyi commented Oct 25, 2017

@JukkaL

Can you fix the merge conflict?

Fixed!

@ilevkivskyi

This comment has been minimized.

Show comment
Hide comment
@ilevkivskyi

ilevkivskyi Oct 25, 2017

Collaborator

@JukkaL I also now removed some code duplication in code added for NewType and existing code for NamedTuple (see last commit).

Collaborator

ilevkivskyi commented Oct 25, 2017

@JukkaL I also now removed some code duplication in code added for NewType and existing code for NamedTuple (see last commit).

@JukkaL

JukkaL approved these changes Oct 25, 2017

Nice, it's good to have less code duplication!

@JukkaL JukkaL merged commit 880bf84 into python:master Oct 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

JukkaL added a commit that referenced this pull request Oct 31, 2017

Fix recent crashes in forward refs (#4120)
This adds processing of forward references in two nodes that were 
previously missing: `OverloadedFuncDef` and `NewTypeExpr.info`.

(Note that some tests use `# type: ignore`, the original crash was 
discovered during serialization with errors ignored.)

Fixes #4097.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment