New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running on Python 3.3 is no longer supported #4152

Merged
merged 4 commits into from Oct 24, 2017

Conversation

Projects
None yet
2 participants
@hugovk
Contributor

hugovk commented Oct 23, 2017

For #4036.

@@ -3,6 +3,12 @@ Revision history
List of major changes:
- Upcoming

This comment has been minimized.

@gvanrossum

gvanrossum Oct 23, 2017

Member

I like this -- it makes it easier to collect everything relevant to the next release in one place (rather than having to scour the logs a day before the release).

@gvanrossum

gvanrossum Oct 23, 2017

Member

I like this -- it makes it easier to collect everything relevant to the next release in one place (rather than having to scour the logs a day before the release).

This comment has been minimized.

@hugovk
@hugovk
Show outdated Hide outdated docs/source/revision_history.rst

@hugovk hugovk changed the title from Notify intention to drop support for 3.3 in an upcoming release to Notify running on Python 3.3 is no longer supported Oct 24, 2017

@gvanrossum gvanrossum changed the title from Notify running on Python 3.3 is no longer supported to Running on Python 3.3 is no longer supported Oct 24, 2017

@gvanrossum

This is OK -- are you interested in also making the changes to .travis.yml and setup.py? In the same PR or a different one?

@hugovk

This comment has been minimized.

Show comment
Hide comment
@hugovk

hugovk Oct 24, 2017

Contributor

.travis.yml and setup.py updated here, along with some other documentation files. I expect there's some more code changes possible, but I think they can be in another PR.

Contributor

hugovk commented Oct 24, 2017

.travis.yml and setup.py updated here, along with some other documentation files. I expect there's some more code changes possible, but I think they can be in another PR.

@gvanrossum gvanrossum merged commit 272d0c4 into python:master Oct 24, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Oct 24, 2017

Member

Great! Thanks for finding those other occurrences. The setup.py one was particularly embarrassing -- it would allow installing with 3.2 but then could not type-check 3.2. :-)

Member

gvanrossum commented Oct 24, 2017

Great! Thanks for finding those other occurrences. The setup.py one was particularly embarrassing -- it would allow installing with 3.2 but then could not type-check 3.2. :-)

@hugovk hugovk deleted the hugovk:patch-1 branch Oct 25, 2017

JukkaL added a commit that referenced this pull request Oct 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment