New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stubgen return status 0 on --help #4160

Merged
merged 3 commits into from Oct 26, 2017

Conversation

Projects
None yet
2 participants
@gwerbin
Contributor

gwerbin commented Oct 25, 2017

This lets package managers like conda use stubgen --help as a quick-and-dirty test.

Also it makes more sense if you squint at it a little. The user requested help, so they shouldn't be put in some an error state.

gwerbin added some commits Oct 25, 2017

Make stubgen return status 0 on --help
This lets package managers like conda use `stubgen --help` as a quick-and-dirty test.
Fix a silly mistake
Swapped arg name and type
@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Oct 25, 2017

Member
Member

gvanrossum commented Oct 25, 2017

Fix indentation
Github editor mistake

@gvanrossum gvanrossum merged commit a1ace48 into python:master Oct 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Oct 26, 2017

Member

Thanks!

Member

gvanrossum commented Oct 26, 2017

Thanks!

JukkaL added a commit that referenced this pull request Oct 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment