New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With disallow_untyped_defs, warn for missing return types on async def #4218

Merged
merged 2 commits into from Nov 15, 2017

Conversation

Projects
None yet
2 participants
@JelleZijlstra
Collaborator

JelleZijlstra commented Nov 7, 2017

Fixes #4209.

Under disallow_untyped_defs, we were missing errors for missing return
types on async def functions, because the return type of such functions
is Awaitable[Any] instead of Any.

This PR also removes a duplicate test case (apparently from the fast
parser cleanup) and adds some missing annotations to stubs.

JelleZijlstra added some commits Nov 7, 2017

With disallow_untyped_defs, warn for missing return types on async def
Fixes #4209.

Under disallow_untyped_defs, we were missing errors for missing return
types on async def functions, because the return type of such functions
is Awaitable[Any] instead of Any.

This PR also removes a duplicate test case (apparently from the fast
parser cleanup) and adds some missing annotations to stubs.
@JukkaL

JukkaL approved these changes Nov 15, 2017

LGTM -- thanks for the PR!

@JukkaL JukkaL merged commit e1c569c into python:master Nov 15, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@JelleZijlstra JelleZijlstra deleted the JelleZijlstra:fix4209 branch Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment