New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check right operand of is expressions #4243

Merged
merged 1 commit into from Nov 14, 2017

Conversation

Projects
None yet
2 participants
@ethanhs
Collaborator

ethanhs commented Nov 14, 2017

The right operand of is expressions were not being checked.
Fixes #4055

Check right operand of is expressions
The right operand of `is` expressions were not being checked.
Fixes #4055

@gvanrossum gvanrossum merged commit 1cbab17 into python:master Nov 14, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Nov 14, 2017

Member

Thanks! Of course this found some issues in our internal codebase... But we'll survive.

Member

gvanrossum commented Nov 14, 2017

Thanks! Of course this found some issues in our internal codebase... But we'll survive.

@ethanhs

This comment has been minimized.

Show comment
Hide comment
@ethanhs

ethanhs Nov 14, 2017

Collaborator

You're welcome. And catching bugs is the goal, so it's good bugs were caught :^)

Collaborator

ethanhs commented Nov 14, 2017

You're welcome. And catching bugs is the goal, so it's good bugs were caught :^)

@ethanhs ethanhs deleted the ethanhs:fixisop branch Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment