New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not warn on returning any from deferred node #4295

Merged
merged 2 commits into from Nov 30, 2017

Conversation

Projects
None yet
2 participants
@elazarg
Contributor

elazarg commented Nov 30, 2017

Fix #4296

The access to member defined in __init__ causes the current node to be deferred, so mypy assumes expressions are Any but should not warn about it.

This is not the only conceivable fix - for example, I'm not sure why mypy should continue checking the function in the first place.

@JukkaL

Thanks for the PR, LGTM -- just one minor comment.

Show outdated Hide outdated test-data/unit/check-warnings.test Outdated

@JukkaL JukkaL merged commit b541af9 into python:master Nov 30, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment