New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce better error on invalid types like List(int) #4323

Merged
merged 1 commit into from Dec 5, 2017

Conversation

Projects
None yet
3 participants
@msullivan
Collaborator

msullivan commented Dec 4, 2017

Fixes #4172

@msullivan msullivan requested review from JukkaL and gvanrossum Dec 4, 2017

@gvanrossum

I'd like to see a new test too that checks List(int), another for a user-defined generic class, and yet another proving that it works for Python 2 mode too.

Also, there are a few more related concerns brought up in #4172 -- can you look into fixing those too (if it's not too complicated)?

@msullivan

This comment has been minimized.

Show comment
Hide comment
@msullivan

msullivan Dec 5, 2017

Collaborator

Added some more tests, including a python3 one (the existing one was already python2).

I'm taking a look at the other issues mentioned in the bug and will put up another PR for them.

Collaborator

msullivan commented Dec 5, 2017

Added some more tests, including a python3 one (the existing one was already python2).

I'm taking a look at the other issues mentioned in the bug and will put up another PR for them.

@gvanrossum gvanrossum merged commit 63c656d into master Dec 5, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@gvanrossum gvanrossum deleted the invalid_msg branch Dec 5, 2017

msullivan pushed a commit that referenced this pull request Dec 6, 2017

msullivan pushed a commit that referenced this pull request Dec 6, 2017

JukkaL added a commit that referenced this pull request Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment