New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give better error message for ommited parens in function type #4329

Merged
merged 2 commits into from Dec 7, 2017

Conversation

Projects
None yet
4 participants
@msullivan
Collaborator

msullivan commented Dec 6, 2017

Partially fixes #4323

The direct check for a paren feels janky, but I'm not sure if there is a nicer way.

@msullivan msullivan requested review from JukkaL and gvanrossum Dec 6, 2017

@JukkaL

Mostly LGTM, just a few minor things.

Show outdated Hide outdated mypy/fastparse.py Outdated
@gvanrossum

I'll let Jukka merge this since he started reviewing it.

@JukkaL JukkaL merged commit 0bed269 into master Dec 7, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@gvanrossum gvanrossum deleted the suggest_parens branch Dec 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment