New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest spurious trailing commas as a cause for invalid tuple types #4336

Merged
merged 1 commit into from Dec 7, 2017

Conversation

Projects
None yet
2 participants
@msullivan
Collaborator

msullivan commented Dec 7, 2017

Fixes #4172

This will generate the suggestion in some situations where it is probably not the right thing, unfortunately. (Like when the tuple type is wrapped in parens). That isn't wrong, since this is only a suggestion, but I don't have a good intuition for how likely those cases are.

@msullivan msullivan requested review from JukkaL and gvanrossum Dec 7, 2017

@gvanrossum gvanrossum merged commit 38afbd2 into master Dec 7, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@gvanrossum gvanrossum deleted the trailing_comma branch Dec 7, 2017

@gvanrossum

This comment has been minimized.

Show comment
Hide comment
@gvanrossum

gvanrossum Dec 7, 2017

Member

Short and simple. I like it!

Member

gvanrossum commented Dec 7, 2017

Short and simple. I like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment