New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stubgen: infer None return type for functions without return statement #4467

Merged
merged 3 commits into from Jan 13, 2018

Conversation

Projects
None yet
2 participants
@hoefling
Contributor

hoefling commented Jan 13, 2018

Hi, I added a proposal for the feature implementation requested in #4181, would be grateful for a review! I have doubts about the ellipsis case - should a function containing an ellipsis also have None return type?

Fixes #4181

@ilevkivskyi

Thanks! I like this idea, if no-one has comments then I will merge this soon.

(For future PRs add a line like "Fixes #xxxx", so that GitHub will auto-close the issue when a PR is merged, this time I edited your PR description.)

@ilevkivskyi ilevkivskyi merged commit 6fce774 into python:master Jan 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hoefling hoefling deleted the hoefling:issue-4181 branch Jan 13, 2018

@hoefling

This comment has been minimized.

Contributor

hoefling commented Jan 13, 2018

@ilevkivskyi Wow, that was fast! Thank you for the response and for the hint, I will remember that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment