New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying multiple packages on the command line alongside modules #4733

Merged
merged 1 commit into from Mar 19, 2018

Conversation

Projects
None yet
3 participants
@eric-wieser
Contributor

eric-wieser commented Mar 14, 2018

Fixes #4732

Let me know how best to add tests for this, if you think they're needed.

@gvanrossum

This comment has been minimized.

Member

gvanrossum commented Mar 14, 2018

@eric-wieser

This comment has been minimized.

Contributor

eric-wieser commented Mar 14, 2018

CI output wasn't showing up when I looked before. I'll take a look later today

@eric-wieser

This comment has been minimized.

Contributor

eric-wieser commented Mar 15, 2018

Alright, fixed.

@gvanrossum

This comment has been minimized.

Member

gvanrossum commented Mar 15, 2018

Hm, we don't seem to have tests for -m and -p at all... Could you add some? They would go in test-data/unit/cmdline.test.

@eric-wieser

This comment has been minimized.

Contributor

eric-wieser commented Mar 15, 2018

Tests don't run at all locally for my machine, so I'm gonna hijack the CI to do my testing...

(fails with AssertionError: De-serialization failure: TypeInfo not fixed when I run python setup.py test)

@eric-wieser

This comment has been minimized.

Contributor

eric-wieser commented Mar 15, 2018

Ok, test added

@gvanrossum

This comment has been minimized.

Member

gvanrossum commented Mar 15, 2018

@eric-wieser

This comment has been minimized.

Contributor

eric-wieser commented Mar 19, 2018

Are you happy with the test I've added here? Seems to pass locally and on CI

@gvanrossum

Yes, that's exactly the kind of test I was thinking of. The rest of the code looks good too. I'll ask Ivan if he thinks this makes the cur for this week's release (if not, there'll be another release in 3 weeks).

@ilevkivskyi ilevkivskyi merged commit 00ca3f6 into python:master Mar 19, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment