New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashes in coverage reports #4978

Merged
merged 1 commit into from Apr 26, 2018

Conversation

Projects
None yet
2 participants
@msullivan
Collaborator

msullivan commented Apr 26, 2018

There are two parts to this:

  1. Look harder for the start of a function, since decorators can make
    it tricky to find.
  2. Be more defensive about handling dodgy line number info.
    Our line numbers aren't reliable enough to be crashing the
    reporter over. This fixes a crash related to attrs.

Fixes #4563

Fix crashes in coverage reports
There are two parts to this:
 1. Look harder for the start of a function, since decorators can make
    it tricky to find.
 2. Be more defensive about handling dodgy line number info.
    Our line numbers aren't reliable enough to be crashing the
    reporter over. This fixes a crash related to attrs.

Fixes #4563

@msullivan msullivan requested a review from JukkaL Apr 26, 2018

@JukkaL

JukkaL approved these changes Apr 26, 2018

LGTM -- feel free to merge once the builds have passed.

@JukkaL JukkaL merged commit 121e08e into master Apr 26, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@msullivan msullivan deleted the linecount-fix branch Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment