New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Cleanup DataSuite fields #5075

Merged
merged 2 commits into from May 19, 2018

Conversation

Projects
None yet
2 participants
@elazarg
Contributor

elazarg commented May 18, 2018

Simple changes to DataSuite, I believe they make things somewhat more readable and explicit.

  • Default base_path to test_temp_dir; this clearly marks tests that do something unusual
  • Rename optional_out to required_out_section and default to False
  • Remove update_data, and inline the only place it is used. The flag might be reintroduced if the functionality will be shared with other suites
  • Document reason for data_prefix, since it is not written anywhere
Cleanup DataSuite fields
* Default base_path to test_temp_dir
* Rename optional_out to required_out_section and default to False
* Remove update_data, and inline the only place it is used
* Document reason for data_prefix
base_path = test_temp_dir
# Allow mypyc to update to using a recent version of mypy. See #4779

This comment has been minimized.

@msullivan

msullivan May 18, 2018

Collaborator

I would say "Allow external users of the test code to override the data prefix" or something

@msullivan

Thanks for the cleanup!

@msullivan msullivan merged commit 1566118 into python:master May 19, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment