New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an aststrip crash #5091

Merged
merged 1 commit into from May 21, 2018

Conversation

Projects
None yet
2 participants
@msullivan
Collaborator

msullivan commented May 21, 2018

Bug found testing on Zulip.

Don't blithely index into self.names, since stripping ImportAll
deletes entries.

Fix an aststrip crash
Bug found testing on Zulip.

Don't blithely index into self.names, since stripping ImportAll
deletes entries.

@msullivan msullivan requested review from JukkaL and ilevkivskyi May 21, 2018

@JukkaL

JukkaL approved these changes May 21, 2018

I like how this simplifies the implementation. LGTM!

@msullivan msullivan merged commit 6a934d3 into master May 21, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@msullivan msullivan deleted the crash-fix branch May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment