Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test_stubs and test_samples to pytest #5142

Merged
merged 2 commits into from Jun 23, 2018

Conversation

Projects
None yet
4 participants
@elazarg
Copy link
Contributor

elazarg commented Jun 4, 2018

Using the api, similarly to #5087.

stdlibsamples is not included in this PR since it requires special handling of working directory and paths.

This is another item for #1673.

@ethanhs

This comment has been minimized.

Copy link
Collaborator

ethanhs commented Jun 4, 2018

Hm, we will have to be careful with this and #5051. I think it should be fine for me to rebase my PR on this.

run_mypy(mypy_args + [f])


def find_files(base: str, prefix: str = '', suffix: str = '') -> List[str]:

This comment has been minimized.

@ethanhs

ethanhs Jun 4, 2018

Collaborator

Perhaps these should be moved to mypy.test.helpers since they are used outside of this file?

This comment has been minimized.

@elazarg

elazarg Jun 4, 2018

Author Contributor

I don't think so. It's a temporary hack in runtests.py, and should be moved here soon.

This comment has been minimized.

@ethanhs

ethanhs Jun 4, 2018

Collaborator

Ah, that is true. I think this okay then.

@ethanhs

ethanhs approved these changes Jun 4, 2018

@msullivan

This comment has been minimized.

Copy link
Collaborator

msullivan commented Jun 12, 2018

Any reason not to merge this now?

@gvanrossum

This comment has been minimized.

Copy link
Member

gvanrossum commented Jun 12, 2018

@msullivan

Any reason not to merge this now?

I haven't had the time to review it. If you trust Ethan and/or you've reviewed (and preferably tested) it yourself, go right ahead!

@ethanhs

This comment has been minimized.

Copy link
Collaborator

ethanhs commented Jun 22, 2018

@elazarg It seems there is a merge conflict. When you fix the merge conflict please also delete 3.3 from the list of tested typeshed directories.

@elazarg

This comment has been minimized.

Copy link
Contributor Author

elazarg commented Jun 22, 2018

@ethanhs done (I've also removed 3.4)

modules = []
# TODO: This should also test Python 2, and pass pyversion accordingly.
for version in ["2and3", "3", "3.5"]:
# FIX: remove 'builtins', this directory does not exist

This comment has been minimized.

@gvanrossum

gvanrossum Jun 23, 2018

Member

What does "FIX:" mean? Is it a TODO? Why not do it now?

This comment has been minimized.

@elazarg

elazarg Jun 24, 2018

Author Contributor

I guess you are right. I think I didn't want to change anything

@gvanrossum gvanrossum merged commit 88a6a4e into python:master Jun 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.