Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two option handling bugs in dmypy #5172

Merged
merged 2 commits into from Jun 9, 2018

Conversation

Projects
None yet
2 participants
@msullivan
Copy link
Collaborator

msullivan commented Jun 8, 2018

  1. Make sure to use the right options when processing pass3 semanal in triggers
  2. Don't throw away ignore_errors when processing triggers

Fixes #5168

Fix two option handling bugs in dmypy
1. Make sure to use the right options when processing pass3 semanal in triggers
2. Don't throw away `ignore_errors` when processing triggers

Fixes #5168
@@ -852,9 +852,6 @@ def key(node: DeferredNode) -> int:

nodes = sorted(nodeset, key=key)

# TODO: ignore_all argument to set_file_ignored_lines
manager.errors.set_file_ignored_lines(file_node.path, file_node.ignored_lines)

This comment has been minimized.

@ilevkivskyi

ilevkivskyi Jun 8, 2018

Collaborator

It looks like this change breaks the # type: ignore in fine grained mode.

This comment has been minimized.

@msullivan

msullivan Jun 8, 2018

Author Collaborator

Argh I thought I had run the tests >_>

@ilevkivskyi ilevkivskyi merged commit 922cca1 into master Jun 9, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ilevkivskyi ilevkivskyi deleted the dmypy-options branch Jun 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.