GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
By letting typeshed do the work.
Fixes #2124, #2127, #4788.
support additional args to namedtuple
My change ends up requiring list to exist in all of these tests. It was easier to just change the namedtuple call than to add [builtins fixtures/list.pyi] everywhere. I left a few with the list to make sure we test that code path.
This no longer worked because my stub for namedtuple just has str. Apparently we don't support Text in the test stubs, so I just moved this test case to the pythoneval tests.
This was needed because a few tests that import collections didn't have ... available in their fixtures, and my stub for namedtuple uses it.
This test stopped working because this error is now caught during type checking rather than semanal.
fix test; remove unnecessary fixture
support 3.7 defaults
remove function I didn't need
fix long line
remove redundant argument
fix error in self-check
Did anyone else review this yet? It seems oddly stalled (I wonder what happened around June 13, a number of PRs saw their last activity around that date).
No. As far as I can see, it's ready for review.
I can review it later today.
Thanks for the fixes! Here are few comments.
Thanks for the review! I will push an update soon.
respond to code review
pass the actual defaults
Will fix the CI failure later today.
Thanks! One last comment. Could you please also fix the self-check? You can merge it after all tests pass.
fix CI; remove obsolete comment
So the initial description said "Fixes #2124, #2127, #4788." And only #2124 got auto-closed (auto-close isn't smart enough :-). Should the other two also be closed now?
Thanks for catching that! I'll close the other ones too.
I suppose I should have written "Fixes #2124. Fixes #2127. Fixes #4788."