Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give output of failed venv creation in PEP 561 tests #5237

Merged
merged 1 commit into from Jun 19, 2018

Conversation

Projects
None yet
4 participants
@ethanhs
Copy link
Collaborator

ethanhs commented Jun 19, 2018

This made it harder to realize what was going wrong in #5234 (sorry Michael and Ivan).

I also added a note about why we need virtualenv.

@ethanhs ethanhs requested a review from Michael0x2a Jun 19, 2018

@Michael0x2a
Copy link
Collaborator

Michael0x2a left a comment

lgtm

@JelleZijlstra

This comment has been minimized.

Copy link
Collaborator

JelleZijlstra commented Jun 19, 2018

To make this kind of bug less likely, should we make run_command default to throwing an exception if the command fails?

@ethanhs

This comment has been minimized.

Copy link
Collaborator Author

ethanhs commented Jun 19, 2018

@JelleZijlstra I do think that it may be a good idea. I think it will be better for that to be in a separate PR.

@ilevkivskyi ilevkivskyi merged commit 2f2f8e5 into python:master Jun 19, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ethanhs ethanhs deleted the ethanhs:printvirtualenv branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.