Refactor and reorder search path #5256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
approved these changes
Jun 22, 2018
mypy/build.py
Outdated
| @@ -188,10 +188,43 @@ def default_flush_errors(new_messages: List[str], is_serious: bool) -> None: | |||
| raise | |||
|
|
|||
|
|
|||
| def compute_lib_path(sources: List[BuildSource], | |||
| SearchPaths = NamedTuple('SearchPaths', | |||
There was a problem hiding this comment.
Could you please add a comment above documenting the fields and a typical usage.
mypy/build.py
Outdated
|
|
||
| # Prepend a config-defined mypy path. | ||
| lib_path.extendleft(options.mypy_path) | ||
| # Start with a MYPYPATH environment variable to front of library path, if defined. |
There was a problem hiding this comment.
This sentence reads a bit weird. Did you mean "prepend"?
|
(Hm, also there is a merge conflict now.) |
|
@ilevkivskyi this should be ready to try on another code base. I think I will tackle (finally) setuptools support next. It should be faily straightforward. |
|
Before merging this I also should probably update https://mypy.readthedocs.io/en/latest/command_line.html#how-imports-are-found (which I will do shortly). E: Done. |
gvanrossum
pushed a commit
that referenced
this pull request
Jun 30, 2018
With my refactoring in #5256, I realized that it would be pretty straightforward to give some nicer warnings if site-packages were in any of the PATHs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in #5227, here is an implementation for refactoring and making the search path compliant with PEP 561. The order is specified in https://www.python.org/dev/peps/pep-0561/#type-checker-module-resolution-order.
This is also my first PR from an airplane :)