Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module __getattr__ in incremental mode #5306

Merged
merged 2 commits into from Jul 3, 2018

Conversation

Projects
None yet
2 participants
@ilevkivskyi
Copy link
Collaborator

ilevkivskyi commented Jul 3, 2018

For module __getattr__ to work correctly in incremental mode, we need to de-serialise potential parent package files during an attempt to find a partial package. Otherwise there will be spurious "Module not found" errors during the second and subsequent runs.

@ilevkivskyi ilevkivskyi requested a review from gvanrossum Jul 3, 2018

@ilevkivskyi ilevkivskyi merged commit 44e789d into python:master Jul 3, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ilevkivskyi ilevkivskyi deleted the ilevkivskyi:fix-getattr-incremental branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.