New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't treat functions with reversible dunder names as such #5421

Merged
merged 6 commits into from Aug 5, 2018

Conversation

Projects
None yet
3 participants
@srittau
Contributor

srittau commented Aug 5, 2018

Previously, functions that had the same name as a reversible dunder method (for example, __rpow__) were checked as if they were such a method. This could lead to crashes and false positives.

Closes: #5419

srittau added some commits Aug 5, 2018

Don't treat functions with reversible dunder names as such
Previously, functions that had the same name as a reversible dunder
method (for example, __rpow__) were checked as if they were such a
method. This could lead to crashes and false positives.

Closes: #5419
@Michael0x2a

Looks good to me -- my comments below are just me nitpicking. I'll merge once you've had a chance to look through the feedback.

Show outdated Hide outdated mypy/messages.py Outdated
Show outdated Hide outdated test-data/unit/check-modules.test Outdated
@ethanhs

ethanhs approved these changes Aug 5, 2018

I ran into this when running mypy against the CPython code base where it was invalidly complained about. Thank you for fixing this!

@Michael0x2a Michael0x2a merged commit 1222c96 into python:master Aug 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Michael0x2a

This comment has been minimized.

Show comment
Hide comment
@Michael0x2a

Michael0x2a Aug 5, 2018

Collaborator

Thanks!

Collaborator

Michael0x2a commented Aug 5, 2018

Thanks!

@srittau srittau deleted the srittau:fix-5419 branch Aug 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment