GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Previously, functions that had the same name as a reversible dunder method (for example, __rpow__) were checked as if they were such a method. This could lead to crashes and false positives.
Add a test case exposing #5419
Add an assertion to operator_method_signatures_overlap()
Add an assertion to check_reverse_op_method()
Don't treat functions with reversible dunder names as such
Previously, functions that had the same name as a reversible dunder
method (for example, __rpow__) were checked as if they were such a
method. This could lead to crashes and false positives.
Looks good to me -- my comments below are just me nitpicking. I'll merge once you've had a chance to look through the feedback.
Remove superfluous overload
Add more dunder names as function tests
I ran into this when running mypy against the CPython code base where it was invalidly complained about. Thank you for fixing this!