New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing fine-grained dependencies when using Type[X] #5607

Merged
merged 1 commit into from Sep 19, 2018

Conversation

Projects
None yet
2 participants
@JukkaL
Collaborator

JukkaL commented Sep 12, 2018

Now X.__init__ triggers uses of Type[X], since Type[X] is
callable and the signature is derived from X.__init__ (or
__new__).

I also verified that this works end-to-end but I decided not to add a
test case since the existing ones seem to provide enough coverage.

This generates some dependencies that aren't necessary, but they seem
pretty benign.

Add missing fine-grained dependencies when using Type[X]
Now `X.__init__` triggers uses of `Type[X]`, since `Type[X]` is
callable and the signature is derived from `X.__init__` (or
`__new__`).

I also verified that this works end-to-end but I decided not to add a
test case since the existing ones seem to provide enough coverage.

This generates some dependencies that aren't necessary, but they seem
pretty benign.

@JukkaL JukkaL requested a review from ilevkivskyi Sep 18, 2018

@ilevkivskyi

The diff looks large but this is only due to refactoring (which actually makes sense).

I think the redundant deps will not cause any harm, LGTM.

@ilevkivskyi ilevkivskyi merged commit 88e49e7 into master Sep 19, 2018

3 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ilevkivskyi ilevkivskyi deleted the fg-type-type branch Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment