Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Defer subclass methods if superclass has not been analyzed #5637
Thanks for working on this issue -- when users hit this issue, it's very confusing. It's totally unclear why mypy is complaining and how to fix the problem.
Left detailed comments since deferred nodes are a very tricky part of mypy. Once you are updating this code it's a good opportunity to add some more documentation.
@JukkaL Thanks for review! I addressed the comments. I decided to have a separate
I also added a bunch of tests combining overloads, decorators, variables, double deferrals, and super calls (also with various combinations of these).
Thanks for the cleanups! Looks better. I left a few more comments. Feel free to merge once you've addressed them.