New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ClassVar #5733

Merged
merged 3 commits into from Oct 16, 2018

Conversation

Projects
None yet
4 participants
@nanjekyejoannah
Copy link
Contributor

nanjekyejoannah commented Oct 4, 2018

This PR fixes #5546.

I have added a section in the class basics documentation with details on when, how and when not to use ClassVar.

cc @ilevkivskyi

@ilevkivskyi

This comment has been minimized.

Copy link
Collaborator

ilevkivskyi commented Oct 4, 2018

I think @JukkaL might want to review this.

@JukkaL
Copy link
Collaborator

JukkaL left a comment

Thanks for writing more documentation! Left some comments -- mostly style/flow issues.

Show resolved Hide resolved docs/source/class_basics.rst Outdated
Show resolved Hide resolved docs/source/class_basics.rst Outdated
Show resolved Hide resolved docs/source/class_basics.rst
Show resolved Hide resolved docs/source/class_basics.rst
Show resolved Hide resolved docs/source/class_basics.rst
Show resolved Hide resolved docs/source/class_basics.rst Outdated
@gvanrossum

This comment has been minimized.

Copy link
Member

gvanrossum commented Oct 7, 2018

Hey @nanjekyejoannah, do you want to push an updated version in response to Jukka's review? There's still time to get this cherry-picked in the upcoming 0.640 release.

@nanjekyejoannah
Copy link
Contributor

nanjekyejoannah left a comment

@gvanrossum Apologies for a late response. Been traveling for ages :). I have made the necessary changes. @JukkaL PTAL.

Show resolved Hide resolved docs/source/class_basics.rst
Show resolved Hide resolved docs/source/class_basics.rst Outdated
Show resolved Hide resolved docs/source/class_basics.rst Outdated
@JukkaL

JukkaL approved these changes Oct 16, 2018

Copy link
Collaborator

JukkaL left a comment

Thanks for the updates! Looks good. There are a few things I'll probably tweak in a separate PR but this is fine as is.

@JukkaL JukkaL merged commit b67530e into python:master Oct 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment