New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constraint inference for non-invariant instances #5817

Merged
merged 3 commits into from Oct 22, 2018

Conversation

Projects
None yet
2 participants
@ilevkivskyi
Copy link
Collaborator

ilevkivskyi commented Oct 22, 2018

Fixes #2035

Note that in two tests we now infer object instead of giving an error. This may be not what a user expects, but I think this is still OK, and after #3816 mypy will always ask for an annotation in such cases.

JukkaL and others added some commits Mar 19, 2018

Merge remote-tracking branch 'upstream/master' into fix-infer-generic
Conflicts:
	test-data/unit/check-inference-context.test
@JukkaL

JukkaL approved these changes Oct 22, 2018

Copy link
Collaborator

JukkaL left a comment

LGTM. I'd suggest checking this against internal Dropbox codebases before merging.

@ilevkivskyi

This comment has been minimized.

Copy link
Collaborator

ilevkivskyi commented Oct 22, 2018

Internal codebase is clean.

@ilevkivskyi ilevkivskyi merged commit 2b71c2f into python:master Oct 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ilevkivskyi ilevkivskyi deleted the ilevkivskyi:fix-infer-generic branch Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment