New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when reveal_locals() encounters a class definition #5920

Merged
merged 3 commits into from Nov 20, 2018

Conversation

Projects
None yet
1 participant
@gvanrossum
Copy link
Member

gvanrossum commented Nov 20, 2018

Fixes #5915.

The root cause were some improper casts when creating the local_nodes list. These were easy to fix by adding isinstance(node, Var) checks to the list comprehensions.

@gvanrossum

This comment has been minimized.

Copy link
Member

gvanrossum commented Nov 20, 2018

Since this was a super simple fix I'll just merge it now.

@gvanrossum gvanrossum merged commit 3c311c2 into python:master Nov 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gvanrossum gvanrossum deleted the gvanrossum:fix-reveal_locals-crash branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment