New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't map actual **kwargs to formal *args #6096

Merged
merged 2 commits into from Dec 20, 2018

Conversation

Projects
None yet
2 participants
@JukkaL
Copy link
Collaborator

JukkaL commented Dec 20, 2018

The fix was originally proposed by @elazarg.

Fixes #1969.

Don't map actual **kwargs to formal *args
The fix was originally proposed by @elazarg.

Fixes #1969.
@ilevkivskyi
Copy link
Collaborator

ilevkivskyi left a comment

Thank you! I have just one test suggestion.


m = {} # type: Mapping[str, object]
f(**m)
[builtins fixtures/dict.pyi]

This comment has been minimized.

@ilevkivskyi

ilevkivskyi Dec 20, 2018

Collaborator

Maybe also add the second test case mentioned in the issue? The one with:

def b(arg: str='', **kw: int) -> None:
    pass

@JukkaL JukkaL merged commit d61babb into master Dec 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@JelleZijlstra JelleZijlstra deleted the bug-kwargs branch Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment