New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect timing stats and allow reporting of stats from the daemon #6137

Merged
merged 4 commits into from Jan 4, 2019

Conversation

Projects
None yet
3 participants
@msullivan
Copy link
Collaborator

msullivan commented Jan 4, 2019

There are a couple related pieces here:

  • Add a bunch of timing information to the stats tracked by BuildManager
  • Include all the stats in the dmypy server responses
  • Add a --telemetry-file argument to dmypy check et. al that writes out
    the stats information to a file

This will allow the collection of much more detailed internal
profiling information.

Collect timing stats and allow reporting of stats from the daemon
There are a couple related pieces here:
 * Add a bunch of timing information to the stats tracked by BuildManager
 * Include all the stats in the dmypy server responses
 * Add a --telemetry-file argument to dmypy check et. al that writes out
   the stats information to a file

This will allow the collection of much more detailed internal
profiling information.

@msullivan msullivan requested review from JukkaL and ilevkivskyi Jan 4, 2019

@ilevkivskyi
Copy link
Collaborator

ilevkivskyi left a comment

LGTM.

I didn't think much about what would be useful, but the stats gathered in this PR look more than enough.

Show resolved Hide resolved mypy/dmypy.py Outdated

@msullivan msullivan force-pushed the profiling branch from 1268541 to d74481d Jan 4, 2019

@msullivan msullivan merged commit 49ad7de into master Jan 4, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msullivan msullivan deleted the profiling branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment