Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give better error message (and don't crash) if bad json in the cache #6277

Merged
merged 5 commits into from Feb 7, 2019

Conversation

Projects
None yet
2 participants
@ethanhs
Copy link
Collaborator

commented Jan 31, 2019

Hopefully this seems reasonable.

Fixes #6156

ethanhs added some commits Jan 31, 2019

Show resolved Hide resolved mypy/build.py Outdated
Show resolved Hide resolved mypy/build.py Outdated
@ethanhs

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 2, 2019

@gvanrossum This now is a bit nicer I think, it reports the error like so:

_ast.meta.json:0: error: Error reading JSON file; you likely have a bad cache.
Try removing the .mypy_cache directory and run mypy again.
Show resolved Hide resolved mypy/build.py Outdated
@gvanrossum
Copy link
Member

left a comment

Thanks for your patience! And sorry for taking so long to review.

@ethanhs ethanhs merged commit ffd0870 into python:master Feb 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ethanhs ethanhs deleted the ethanhs:catchbadcache branch Feb 7, 2019

@ethanhs

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 7, 2019

Thanks for your patience! And sorry for taking so long to review.

No worries! Thank you for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.