Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin invocation for `__call__` methods #6334

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
2 participants
@oremanj
Copy link
Contributor

commented Feb 5, 2019

Previously these would be delivered as a function hook for __call__ of Foo;
now they are more properly a method hook for __main__.Foo.__call__.
Also make sure we call the method signature hook for __call__ methods.

Fix plugin invocation for `__call__` methods
Previously these would be delivered as a function hook for `__call__ of Foo`;
now they are more properly a method hook for `__main__.Foo.__call__`.
@ilevkivskyi
Copy link
Collaborator

left a comment

Thanks for the fix! Looks good.

@ilevkivskyi ilevkivskyi merged commit e9dc189 into python:master Feb 5, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@oremanj oremanj referenced this pull request Feb 5, 2019

Closed

Release 0.670 planning #6271

gvanrossum added a commit to gvanrossum/mypy that referenced this pull request Feb 5, 2019

Fix plugin invocation for `__call__` methods (python#6334)
Previously these would be delivered as a function hook for `__call__ of Foo`;
now they are more properly a method hook for `__main__.Foo.__call__`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.