Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete pyproject.toml to work around pip bug #6342

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
3 participants
@msullivan
Copy link
Collaborator

commented Feb 5, 2019

We run afoul of pypa/pip#6163, which
prevents directly pip installing mypy from a source directory with pip
19.0 (because our setup.py imports from mypy for version number
related reasons).

Once a bugfix for that is out we can probably restore it.

Delete pyproject.toml to work around pip bug
We run afoul of pypa/pip#6163, which
prevents directly pip installing mypy from a source directory with pip
19.0 (because our setup.py imports from mypy for version number
related reasons).

Once a bugfix for that is out we can probably restore it.

@msullivan msullivan requested a review from gvanrossum Feb 5, 2019

@gvanrossum

This comment has been minimized.

Copy link
Member

commented Feb 5, 2019

(CC: @gaborbernat who introduced this file.)

@gvanrossum gvanrossum referenced this pull request Feb 5, 2019

Closed

Release 0.670 planning #6271

@gaborbernat

This comment has been minimized.

Copy link
Contributor

commented Feb 5, 2019

the latest setuptools released today introduced the legacy backend which will solve this issue

@gvanrossum gvanrossum merged commit 05bbdc3 into master Feb 5, 2019

3 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gvanrossum gvanrossum deleted the delete-pyproject branch Feb 5, 2019

gvanrossum added a commit to gvanrossum/mypy that referenced this pull request Feb 5, 2019

Delete pyproject.toml to work around pip bug (python#6342)
We run afoul of pypa/pip#6163, which
prevents directly pip installing mypy from a source directory with pip
19.0 (because our setup.py imports from mypy for version number
related reasons).

Once a bugfix for that is out we can probably restore it.
@msullivan

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 5, 2019

Excellent. We'll revert this once there is a pip 19 release that defaults to using the legacy backend.

(We could directly ask to use it ourselves, but that seems dodgy since it has a bunch of underscores in the name and would make us require a very recent setuptools ourselves)

@gaborbernat

This comment has been minimized.

Copy link
Contributor

commented Feb 5, 2019

The main reasons for making it underscore is because importing from setup.py is considered a bad practice, not necessarily because it's actually dodgy using it.I think if we do want to really on importing from setup.py the version we might as well be upfront about it. I'll link in the discussion about the subject tomorrow. I'm not sure if pip will default to it though, AFAIK the intention is to be more like a bailout mechanism for packages who do want this behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.