Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to skip mtime checks on cache files #6391

Merged
merged 1 commit into from Feb 14, 2019

Conversation

Projects
None yet
2 participants
@msullivan
Copy link
Collaborator

commented Feb 13, 2019

When using an externally generated sqlite cache in daemon mode,
we should already trust that the cache is valid, and all the mtime
checks are surprisingly slow. (About 1s on S on my MBP.)

Allow skipping these.

An alternative I considered was to just always skip them when using
a sqlite cache, but I think we'd need to be more careful about
when we commit if we want to guarentee cache integrity.

Add a flag to skip mtime checks on cache files
When using an externally generated sqlite cache in daemon mode,
we should already trust that the cache is valid, and all the mtime
checks are surprisingly slow. (About 1s on S on my MBP.)

Allow skipping these.

An alternative I considered was to just always skip them when using
a sqlite cache, but I think we'd need to be more careful about
when we commit if we want to guarentee cache integrity.

@msullivan msullivan requested review from JukkaL and gvanrossum Feb 13, 2019

@gvanrossum
Copy link
Member

left a comment

Did you test this manually? Given that there are no tests for this and it's not easily testable.

@msullivan

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 13, 2019

Yeah

@msullivan msullivan merged commit 6bd8096 into master Feb 14, 2019

3 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msullivan msullivan deleted the skip-mtime-validation branch Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.