Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call abspath() on path name when validating cache #6405

Merged
merged 2 commits into from Feb 15, 2019

Conversation

Projects
None yet
2 participants
@msullivan
Copy link
Collaborator

commented Feb 15, 2019

abspath() is surprisingly slow. This gave almost a second of speedup
for me on cold run startup.

This does change the cache contents, but I don't think it should
really matter.

Don't call abspath() on path name when figuring out cache.
abspath() is surprisingly slow. This gave almost a second of speedup
for me on cold run startup.

This does change the cache contents, but I don't think it should
really matter.

@msullivan msullivan requested review from ilevkivskyi and JukkaL Feb 15, 2019

@gvanrossum

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

Note that normpath doesn’t turn absolute paths into regular paths. That’s probably OK, but some use cases could be affected.

@msullivan

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 15, 2019

Our normpath function doesn't ever actually call normpath, though: it calls relpath in bazel mode and abspath otherwise

@gvanrossum
Copy link
Member

left a comment

Gotcha. Though I regret calling it normpath — I totally misread that. ;-(

@msullivan msullivan merged commit bae8f60 into master Feb 15, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msullivan msullivan deleted the no_normpath branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.