Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Expression-scoped ignores in Python 3.8. #6648
Fixes #1032. On Python 3.8, we use
A few notes:
Thanks for the feedback @ilevkivskyi! I've gone ahead and addressed your concerns, and am ready for another review.
I've chosen to maintain a set of source comment lines as you suggested, in addition to the mapping of ignore scopes. One nice benefit is, with a change in the order of traversal, we can now avoid expensive dictionary copies at each ignored expression node.