Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn all warnings and bare notes into errors #6650

Merged
merged 5 commits into from Apr 11, 2019

Conversation

@msullivan
Copy link
Collaborator

commented Apr 9, 2019

This means that all diagnostics are errors, which maybe have some
notes "attached" to them.
This makes sense, since all diagnostics cause an error exit code.

Fixes #6574.

Turn all warnings and bare notes into errors
This means that all diagnostics are errors, which maybe have some
notes "attached" to them.
This makes sense, since all diagnostics cause an error exit code.

Fixes #6574.
@gvanrossum
Copy link
Member

left a comment

Near the top of errors.py there's a comment stating that severity can be "Either 'error', 'note', or 'warning'." Presumably this should be updated.

msullivan added some commits Apr 11, 2019

@msullivan msullivan merged commit 579705d into master Apr 11, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@msullivan msullivan deleted the no-warnings branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.