Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update third party modules #6781

Merged
merged 3 commits into from May 6, 2019

Conversation

@matys18
Copy link
Contributor

commented May 6, 2019

Fixes #6767 馃敡

Updated the third party module list with the top 200 packages of the past 365 days from here. Not entirely sure how reliable the data is, however, the old source has been deprecated and has not been updated in a while.

Update third party modules
Fixes #6767. Updated the third party module list with the top 200
packages of the past 365 days from: https://hugovk.github.io/top-pypi-packages/
@JukkaL
Copy link
Collaborator

left a comment

Thanks for the PR! Unfortunately some of the names are not the actual importable package names, and mypy can't use these to generate better error messages.

mypy/moduleinfo.py Outdated Show resolved Hide resolved
mypy/moduleinfo.py Outdated Show resolved Hide resolved

matys18 added some commits May 6, 2019

Clean third party module list
Addressing @JukkaL comments. Made sure that the third party module
list only contains module names, not package names.
@matys18

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

@JukkaL My bad. I've updated the list to contain the actual package names instead.

Tested it by installing the top 200 packages in a venv and then looping over the new list in this PR in order to check if each element is importable.

@JukkaL

JukkaL approved these changes May 6, 2019

Copy link
Collaborator

left a comment

Looks good, thanks for the updates!

@ilevkivskyi ilevkivskyi merged commit cc850ae into python:master May 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.