Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask user about __init__ on duplicate packages #6785

Merged
merged 3 commits into from May 7, 2019

Conversation

@jxcl
Copy link
Contributor

commented May 6, 2019

Fixes #5743

mypy/build.py Outdated Show resolved Hide resolved
@ilevkivskyi

This comment has been minimized.

Copy link
Collaborator

commented May 6, 2019

I think you might need to add/update some test cases.

@jxcl

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

No test cases broke as far as I could tell, but I'll add a case for triggering the reminder.

@ilevkivskyi
Copy link
Collaborator

left a comment

Thanks! LGTM assuming the added test passes in CI.

@gvanrossum gvanrossum merged commit ac70b55 into python:master May 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jxcl jxcl deleted the jxcl:5743-forgot-init branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.