Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate non-blocking error for foo few/many arguments in type comment #6813

Merged
merged 2 commits into from May 10, 2019

Conversation

@JukkaL
Copy link
Collaborator

commented May 10, 2019

Stubgen doesn't produce any output if there is a blocking error.

JukkaL added some commits Apr 11, 2019

Generate normal error for too few/many arguments in type comment
Blocking error was a problem for stubgen.

@JukkaL JukkaL requested a review from ilevkivskyi May 10, 2019

@ilevkivskyi
Copy link
Collaborator

left a comment

LGTM, thanks for the fix!

@JukkaL JukkaL merged commit e1ef1a2 into master May 10, 2019

3 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@JelleZijlstra JelleZijlstra deleted the stubgen-num-args-error branch May 10, 2019

msullivan added a commit that referenced this pull request May 17, 2019

Make parse errors always blockers in fine-grained mode
Since fine-grained mode doesn't re-run the parser, non-blocking errors get lost.
There are a bunch of different approaches that could fix this but for now just
disable non-blocking errors from the parser in fine-grained mode.

Partially disables #6813.

msullivan added a commit that referenced this pull request May 17, 2019

Make parse errors always blockers in fine-grained mode (#6859)

Since fine-grained mode doesn't re-run the parser, non-blocking errors get lost.
There are a bunch of different approaches that could fix this but for now just
disable non-blocking errors from the parser in fine-grained mode.

Partially disables #6813.

PattenR added a commit to PattenR/mypy that referenced this pull request Jun 23, 2019

Make parse errors always blockers in fine-grained mode (python#6859)

Since fine-grained mode doesn't re-run the parser, non-blocking errors get lost.
There are a bunch of different approaches that could fix this but for now just
disable non-blocking errors from the parser in fine-grained mode.

Partially disables python#6813.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.