Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only honor --warn-unused-configs in non-incremental mode #6829

Merged

Conversation

@gvanrossum
Copy link
Member

commented May 14, 2019

(In incremental mode it doesn't work right, and it isn't worth fixing.)

Fixes #5957

Only honor --warn-unused-configs in non-incremental mode
(In incremental mode it doesn't work right, and it isn't worth fixing.)
@JukkaL

This comment has been minimized.

Copy link
Collaborator

commented May 14, 2019

Looks like some test case needs to be updated to use --no-incremental.

@JukkaL

JukkaL approved these changes May 15, 2019

@gvanrossum gvanrossum merged commit 4cf0471 into python:master May 15, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gvanrossum gvanrossum deleted the gvanrossum:ignore-unused-configs-if-incremental branch May 15, 2019

PattenR added a commit to PattenR/mypy that referenced this pull request Jun 23, 2019

Only honor --warn-unused-configs in non-incremental mode (python#6829)
(In incremental mode it doesn't work right, and it isn't worth fixing.)

Fixes python#5957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.